[node-patches] Change in ovirt-node[master]: ovirt-node-upgrade: catch exceptions that are being skipped ...

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: ovirt-node-upgrade: catch exceptions that are being skipped over
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File scripts/ovirt-node-upgrade.py
Line 297:             self._run_hooks("post-upgrade")
Line 298:             if self._options.reboot > 0:
Line 299:                 self._reboot(self._options.reboot)
Line 300:             self._logger.info("Upgrade Completed")
Line 301:             sys.exit(0)
I'm not sure if sys.exit(0) (which is a syscall) ensures that the finally: section is beeing run, which means that the cleanup is skipped.
Line 302:         except Exception as e:
Line 303:             self._logger.exception('Error: Upgrade Failed: %s', e)
Line 304:             self._run_hooks("rollback")
Line 305:             self._logger.info("Upgrade Failed, Rollback Completed")


--
To view, visit http://gerrit.ovirt.org/14958
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefde860477dc21ca231d5dc29d8b79ab364b2c3f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>