[node-patches] Change in ovirt-node[master]: add return value when persist command does not return an err...

[wenyi at linux.vnet.ibm.com]

Wenyi Gao has posted comments on this change.

Change subject: add return value when persist command does not return an error code on failure
......................................................................


Patch Set 6: I would prefer that you didn't submit this

(1 inline comment)

code looks good, but commit message has some error.

....................................................
Commit Message
Line 11: The "ovirt_store_config" function will invoked the new function "ovirt_store_config_atomic"
Line 12: The ovirt_store_config will judge the error number from the ovirt_store_config_atomic
Line 13: and ovirt_store_config will also return True/False value from the judgement error number
Line 14: In the shell script ovirt-functions.in, invoked the ovirt_store_config_atomic directly
Line 15: 
ovirt_store_config_atomic should be changed to ovirt_store_config_retnum. There is also some grammar error in the commit message.
Line 16: Change-Id: I458adeddeb17f63c5d003db808044ad6c8e9e097


--
To view, visit http://gerrit.ovirt.org/14737
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I458adeddeb17f63c5d003db808044ad6c8e9e097
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Changming Bai <baichm at linux.vnet.ibm.com>
Gerrit-Reviewer: Changming Bai <baichm at linux.vnet.ibm.com>
Gerrit-Reviewer: Eli Qiao <taget at linux.vnet.ibm.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>