[node-patches] Change in ovirt-node[master]: add return value when persist command does not return an err...

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: add return value when persist command does not return an error code on failure
......................................................................


Patch Set 7: I would prefer that you didn't submit this

I agree with Fabian,

There should be a function which does the store_config and raises appropriate exceptions when it fails.  A wrapper can translate those exceptions into integer return codes for use in a bash script.

--
To view, visit http://gerrit.ovirt.org/14737
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I458adeddeb17f63c5d003db808044ad6c8e9e097
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Changming Bai <baichm at linux.vnet.ibm.com>
Gerrit-Reviewer: Changming Bai <baichm at linux.vnet.ibm.com>
Gerrit-Reviewer: Eli Qiao <taget at linux.vnet.ibm.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>