[node-patches] Change in ovirt-node[master]: BZ#966367 Shown the default configured value when enter into...

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: BZ#966367 Shown the default configured value when enter into keyboard page
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

Hey,

thanks for the patch!
Basically fine, just a nitpick on the commit msg.

....................................................
Commit Message
Line 3: AuthorDate: 2013-05-29 10:06:43 +0800
Line 4: Commit:     hadong <hadong0720 at gmail.com>
Line 5: CommitDate: 2013-05-29 10:06:43 +0800
Line 6: 
Line 7: BZ#966367 Shown the default configured value when enter into keyboard page
Please keep the first line < 62 chars

The bug should be referenced like:
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=966367
This line should be placed directly abve the Change-Id: line (or somewhere in that paragraph)
Line 8: 
Line 9: Change-Id: I18b362fb93d1761138a4d64f01824ceb01677a9a


--
To view, visit http://gerrit.ovirt.org/15144
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18b362fb93d1761138a4d64f01824ceb01677a9a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>