[node-patches] Change in ovirt-node[master]: Update reboot task to run async from installer and install m...

fabiand at fedoraproject.org fabiand at fedoraproject.org
Wed May 29 19:57:40 UTC 2013


Fabian Deutsch has posted comments on this change.

Change subject: Update reboot task to run async from installer and install module
......................................................................


Patch Set 6: (1 inline comment)

That one is nice!
Except the one typo

....................................................
File src/ovirt/node/utils/system.py
Line 40: 
Line 41: 
Line 42: def async_reboot(delay=3):
Line 43:     reboot_task = Reboot()
Line 44:     reboot_task.reboot()
yuo need to pass delay here
Line 45: 
Line 46: 
Line 47: def poweroff():
Line 48:     """Poweroff the system


--
To view, visit http://gerrit.ovirt.org/14491
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1b4e048ff56b8c9ebd49a82b3d5546c7c326df8
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>



More information about the node-patches mailing list