[node-patches] Change in ovirt-node[master]: [RFC] edit-node: Remove common prefix from package names

[mburns at redhat.com]

Michael Burns has posted comments on this change.

Change subject: [RFC] edit-node: Remove common prefix from package names
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File tools/edit-node
Line 1733:         # Remove the common prefix to shorten the final filename
Line 1734:         common_prefix = "ovirt-node-plugin-"
Line 1735:         if package.startswith(common_prefix):
Line 1736:             cp_len = len(common_prefix)
Line 1737:             package = package[cp_len:]
wouldn't this be simpler to replace the above 4 lines with:

package = package.replace("ovirt-node-plugin-", "")
Line 1738: 
Line 1739:         return package
Line 1740:     plugins = plugins if type(plugins) is list else [plugins]
Line 1741:     packages = [sane_name_for_plugin(p) for p in plugins]


--
To view, visit http://gerrit.ovirt.org/15206
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e2c413741936d257b5394deb68cf0e2db643c16
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>