[node-patches] Change in ovirt-node[master]: src: Restrict checks on new codebase

[fabiand at fedoraproject.org]

Fabian Deutsch has uploaded a new change for review.

Change subject: src: Restrict checks on new codebase
......................................................................

src: Restrict checks on new codebase

… and disable pylint for now.
Previously the whole codebase was checked, but this always failed,
because it's well known that the legacy codebase is not testable.
Therefor the checks are now only run on the new codebase. pylint has
been disabled for now, because it's to strict and we need to work out a
nice configuration which helps us.

Change-Id: I9650db5128306b24a45d5de59959f2ad1af97327
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/Makefile.check
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/37/15237/1

diff --git a/src/Makefile.check b/src/Makefile.check
index 4e906c1..9bd2254 100644
--- a/src/Makefile.check
+++ b/src/Makefile.check
@@ -1,10 +1,10 @@
 
-PYTHONSOURCES:=$(shell find . -name \*.py -not -path */hacks.py)
+PYTHONSOURCES:=$(shell find . -wholename ./ovirt/\*.py)
 XMLSOURCES:=$(shell find . -name \*.xml -or -name \*.xsl)
 CLEANFILES:=$(shell find . -name \*.pyc -o -name \*.pyo -o -name \*~ -o -name MANIFEST)
 
 
-check-local: check-static-doctests check-static-pep8 check-static-pyflakes check-static-pylint
+check-local: check-static-doctests check-static-pep8 check-static-pyflakes
 	@echo -e "---\n Passed $@\n---"
 
 check-static-xmllint: $(XMLSOURCES:%=%.xmllint)
@@ -25,6 +25,8 @@
 %.pep8:
 	PYTHONPATH=. pep8 -r "$*"
 
+# FIXME Pylint is very strict, needs to be configured
+# Maybe take a peek at a diff. proj. to find a sane configuration
 PYLINT=pylint -f parseable --include-ids=yes --rcfile=.pylintrc
 check-static-pylint: $(PYTHONSOURCES:%=%.pylint)
 	@echo Passed $@


--
To view, visit http://gerrit.ovirt.org/15237
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9650db5128306b24a45d5de59959f2ad1af97327
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>