[node-patches] Change in ovirt-node[master]: status page: Add confirmation dialog page for "reboot" and "...

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: status page: Add confirmation dialog page for "reboot" and "Power off" buttons
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File src/ovirt/node/ui/__init__.py
Line 767:                                contents, height=height)]
Line 768:         self.buttons = [CloseButton("dialog.close")]
Line 769: 
Line 770: 
Line 771: class ConfirmationDialog(Dialog):
This should inherit from InfoDialog - this already has a text field
Line 772:     """A generic dialog showing a text and offering buttons
Line 773:     By default a OK and Close button will be shown.
Line 774:     """
Line 775:     def __init__(self, path, title, text, buttons=None):


--
To view, visit http://gerrit.ovirt.org/15255
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56063e812d898e7e7d5490b15e5845115fe45be0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server