[node-patches] Change in ovirt-node[master]: Fix find_disk return value issue

fabiand at fedoraproject.org fabiand at fedoraproject.org
Mon Oct 7 08:59:22 UTC 2013


Fabian Deutsch has posted comments on this change.

Change subject: Fix find_disk return value issue
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

....................................................
File dracut/ovirt-boot-functions
Line 47:     local found=
Line 48:     # in initramfs, shell does not expand
Line 49:     # /dev/disk/by-id/{ata,cciss,scsi,usb}* correctly,
Line 50:     # so manually enumerate them
Line 51:     for d in $(ls /dev/disk/by-id/$bus* 2>/dev/null); do
Could you please explai in the commit msg why this fixes the problem?
Line 52:         DEVTYPE=
Line 53:         eval $(udev_info $(readlink -f $d) property "--export")
Line 54:         # ID_FS_USAGE is set for partitions
Line 55:         if [ "$DEVTYPE" = "disk" -a "$ID_BUS" = "$bus" ]; then


-- 
To view, visit http://gerrit.ovirt.org/19908
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5cfac7149b00f54e68a83f64cf777f071825697
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes



More information about the node-patches mailing list