[node-patches] Change in ovirt-node[master]: [RFC] boot: Add savedefault to primary boot entry

fabiand at fedoraproject.org fabiand at fedoraproject.org
Wed Oct 9 12:11:10 UTC 2013


Fabian Deutsch has uploaded a new change for review.

Change subject: [RFC] boot: Add savedefault to primary boot entry
......................................................................

[RFC] boot: Add savedefault to primary boot entry

Previously savedefault was only set on the backup (second) boot entry of
the grub cfg. That lead to problems when you wanted to set the primary
entry the default after booting the second one:
1. Boot primary entry (is default)
2. Boot second entry (becomes default, as of savedefault)
3. Reboot - Boots into second entry
4. Boot primary entry (does _not_ become default)
5. Reboot - Boots into second entry
This patch also adds savedefault to the primary boot entry, that way the
primary entry will be set as default when it is selected in the boot
entry. That would lead to the following behavior:
...
4. Boot primary entry (becaomes default, as of new savedefault)
5. Reboot - Boots into primary entry

QUESTION: Or is this maybe a problem of the logic starting in scripts/ovirt-init-functions.sh.in line 1369

Change-Id: I49fcc97af7ac275086dd10ac26f9edad90e7aea9
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1017114
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirtnode/install.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/25/20025/1

diff --git a/src/ovirtnode/install.py b/src/ovirtnode/install.py
index 07ae13c..b99c5ae 100755
--- a/src/ovirtnode/install.py
+++ b/src/ovirtnode/install.py
@@ -116,6 +116,7 @@
     root (hd0,%(partN)d)
     kernel /vmlinuz0 %(root_param)s %(bootparams)s
     initrd /initrd0.img
+    savedefault
     """
         GRUB_BACKUP_TEMPLATE = """
 title BACKUP %(oldtitle)s


-- 
To view, visit http://gerrit.ovirt.org/20025
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I49fcc97af7ac275086dd10ac26f9edad90e7aea9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list