[node-patches] Change in ovirt-node[node-3.0]: installer: Add traceback for exceptions in thread

fabiand at fedoraproject.org fabiand at fedoraproject.org
Thu Oct 10 09:50:31 UTC 2013


Fabian Deutsch has uploaded a new change for review.

Change subject: installer: Add traceback for exceptions in thread
......................................................................

installer: Add traceback for exceptions in thread

Previously it was only reported that an exception happened in the
installer thread, but now traceback was logged. Now also a traceback is
logged to help debugging.

Change-Id: I957d165e552c2ed4d8629e3c1a49804c8f225563
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/installer/core/progress_page.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/65/20065/1

diff --git a/src/ovirt/node/installer/core/progress_page.py b/src/ovirt/node/installer/core/progress_page.py
index d075748..8e1d765 100644
--- a/src/ovirt/node/installer/core/progress_page.py
+++ b/src/ovirt/node/installer/core/progress_page.py
@@ -91,7 +91,7 @@
 
             self.__run()
         except Exception as e:
-            self.logger.error("Error in installer thread: %s" % e)
+            self.logger.exception("Installer thread failed: %s" % e)
 
     def __run(self):
         app = self.progress_plugin.application
@@ -131,8 +131,8 @@
                 self.ui_thread.call(update_ui)
 
         except Exception as e:
+            self.logger.exception("Installer transaction failed")
             msg = "Exception: %s" % repr(e)
-            self.logger.debug(msg, exc_info=True)
             self.ui_thread.call(lambda: log.text(msg))
 
         finally:


-- 
To view, visit http://gerrit.ovirt.org/20065
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I957d165e552c2ed4d8629e3c1a49804c8f225563
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: node-3.0
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list