[node-patches] Change in ovirt-node[node-3.0]: EFI boot:fix grub config filename suffix issue

fabiand at fedoraproject.org fabiand at fedoraproject.org
Thu Oct 10 09:50:32 UTC 2013


Hello hadong,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/20069

to review the following change.

Change subject: EFI boot:fix grub config filename suffix issue
......................................................................

EFI boot:fix grub config filename suffix issue

For fedora, the grub config filename suffix should be "grub.cfg".
And for rhel, this file suffix should be "grub.conf"

Change-Id: I4f1755f9743fcb3d59cdc656499ba140b31792f3
Signed-off-by: hadong <hadong0720 at gmail.com>
---
M src/ovirtnode/install.py
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/69/20069/1

diff --git a/src/ovirtnode/install.py b/src/ovirtnode/install.py
index 783cd8b..f73fabc 100755
--- a/src/ovirtnode/install.py
+++ b/src/ovirtnode/install.py
@@ -93,8 +93,10 @@
         else:
             self.efi_dir_name = "redhat"
         if _functions.is_efi_boot():
-            self.grub_config_file = "/liveos/efi/EFI/%s/grub.cfg" \
-                                     % self.efi_dir_name
+            if self.efi_dir_name == "fedora":
+                self.grub_config_file = "/liveos/efi/EFI/fedora/grub.cfg"
+            else:
+                self.grub_config_file = "/liveos/efi/EFI/redhat/grub.conf"
 
     def grub_install(self):
         if _functions.is_iscsi_install():


-- 
To view, visit http://gerrit.ovirt.org/20069
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f1755f9743fcb3d59cdc656499ba140b31792f3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: node-3.0
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: hadong <hadong0720 at gmail.com>



More information about the node-patches mailing list