[node-patches] Change in ovirt-node[node-3.0]: installer: Fix password page

fabiand at fedoraproject.org fabiand at fedoraproject.org
Thu Oct 10 09:50:33 UTC 2013


Fabian Deutsch has uploaded a new change for review.

Change subject: installer: Fix password page
......................................................................

installer: Fix password page

Due to the cmigration to the new ConfirmedEntry widget, it was missed to
store the password in the password page model. This is now fixed and the
password is stored in the password page model.

Change-Id: I290c69683f6a2a1126533befb4f35b816406ed42
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1007811
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/installer/core/password_page.py
M src/ovirt/node/plugins.py
2 files changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/71/20071/1

diff --git a/src/ovirt/node/installer/core/password_page.py b/src/ovirt/node/installer/core/password_page.py
index 60ea3f8..1201609 100644
--- a/src/ovirt/node/installer/core/password_page.py
+++ b/src/ovirt/node/installer/core/password_page.py
@@ -84,4 +84,5 @@
             self.application.ui.navigate.to_previous_plugin()
         elif changes.contains_any(["admin.password_confirmation",
                                    "button.next"]):
+            self._model.update(effective_changes)
             self.application.ui.navigate.to_next_plugin()
diff --git a/src/ovirt/node/plugins.py b/src/ovirt/node/plugins.py
index 5d0de52..2ac8f86 100644
--- a/src/ovirt/node/plugins.py
+++ b/src/ovirt/node/plugins.py
@@ -253,8 +253,9 @@
         """Called when some widget was changed
         change is expected to be a dict.
         """
-        if type(change) is not dict:
-            self.logger.warning("Change is not a dict: %s" % str(change))
+        if type(change) not in [dict, Changeset]:
+            self.logger.warning("Change is not a dict: %s (%s)" %
+                                (repr(change), type(change)))
 
         change = Changeset(change)
 


-- 
To view, visit http://gerrit.ovirt.org/20071
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I290c69683f6a2a1126533befb4f35b816406ed42
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: node-3.0
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list