[node-patches] Change in ovirt-node[master]: progress_page:fix missed persist /etc/vconsole.conf and /etc...

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: progress_page:fix missed persist /etc/vconsole.conf and /etc/sysconfig/keyboard
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

....................................................
File src/ovirt/node/installer/core/progress_page.py
Line 279: 
Line 280:         def commit(self):
Line 281:             utils.system.Keyboard().set_layout(self.kbd_layout)
Line 282:             fs.Config().persist("/etc/vconsole.conf")
Line 283:             fs.Config().persist("/etc/sysconfig/keyboard")
Please use:

   defaults.Keyboard().update(self.kbd_layout)

This will set they current layout and also persist the correct files. So is eqivalent to the above code.


-- 
To view, visit http://gerrit.ovirt.org/20054
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67ee6eb7287db7a909469a9820508bd3e1835cb2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes