[node-patches] Change in ovirt-node[master]: progress_page:fix missed persist /etc/vconsole.conf and /etc...

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: progress_page:fix missed persist /etc/vconsole.conf and /etc/sysconfig/keyboard
......................................................................


Patch Set 5:

(1 comment)

....................................................
File src/ovirt/node/installer/core/progress_page.py
Line 280:         def commit(self):
Line 281:             model = defaults. Keyboard()
Line 282:             model.update(layout=self.kbd_layout)
Line 283:             tx = model.transaction()
Line 284:             tx()
Yes, a good point to look for a common way to solve this functionality.

With a small patch we can even do:

    defaults.Keyboard().update(layout=self.kbd_layout).commit()

or (with a slightly bigger patch _args_to_keys_mapping needs to return self ) even:

    defaults.Keyboard().commit(layout=self.kbd_layout)


-- 
To view, visit http://gerrit.ovirt.org/20054
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67ee6eb7287db7a909469a9820508bd3e1835cb2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes