[node-patches] Change in ovirt-node[master]: Don't let transactions run on unlock errs

fabiand at fedoraproject.org fabiand at fedoraproject.org
Tue Oct 15 22:49:01 UTC 2013


Fabian Deutsch has uploaded a new change for review.

Change subject: Don't let transactions run on unlock errs
......................................................................

Don't let transactions run on unlock errs

Sometimes it could happen that transactions failed because the lockfile
wasn't locked at the end of a transaction, that's not nice, but also not
fatal.

Change-Id: I0670d2987d09e758cc83189d0367cf8379ccf8a8
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/utils/__init__.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/11/20211/1

diff --git a/src/ovirt/node/utils/__init__.py b/src/ovirt/node/utils/__init__.py
index 22cabdd..b064901 100644
--- a/src/ovirt/node/utils/__init__.py
+++ b/src/ovirt/node/utils/__init__.py
@@ -251,6 +251,8 @@
                 self.prepare()
                 for idx, e in enumerate(self):
                     yield (idx, e)
+        except lockfile.NotLocked:
+            self.logger.warning("The lockfile wasn't locked at the end")
         except Exception as e:
             self.logger.warning("'%s' on transaction '%s': %s - %s" %
                                 (type(e), self, e, e.message))


-- 
To view, visit http://gerrit.ovirt.org/20211
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0670d2987d09e758cc83189d0367cf8379ccf8a8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list