[node-patches] Change in ovirt-node[master]: network: Fix valid bond name description

fabiand at fedoraproject.org fabiand at fedoraproject.org
Fri Oct 18 11:28:34 UTC 2013


Fabian Deutsch has uploaded a new change for review.

Change subject: network: Fix valid bond name description
......................................................................

network: Fix valid bond name description

Previously the desription suggerated that only bond[0-9] was valid. This
patch updates the validator to allow any bond namebetween bond[0-9]{1,2}
and also updates the user facing description.

Change-Id: I62aae14292bcc82412f1d45bd64f85fd7c5be161
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1020662
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/setup/core/network_page.py
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/89/20289/1

diff --git a/src/ovirt/node/setup/core/network_page.py b/src/ovirt/node/setup/core/network_page.py
index 8c458e7..32f05f2 100644
--- a/src/ovirt/node/setup/core/network_page.py
+++ b/src/ovirt/node/setup/core/network_page.py
@@ -129,8 +129,9 @@
         ip_or_empty = valid.IPAddress() | valid.Empty()
         fqdn_ip_or_empty = valid.FQDNOrIPAddress() | valid.Empty()
 
-        valid_bond_name = valid.RegexValidator("^bond[0-9]+|007$",
-                                               "a valid bond name (bond[0-9])")
+        valid_bond_name = valid.RegexValidator("^(bond[0-9]{1,2}|007)$",
+                                               "a valid bond name (bond[0-99])")
+                                               # No regex, but for users ^
 
         return {"hostname": fqdn_ip_or_empty,
                 "dns[0]": ip_or_empty,


-- 
To view, visit http://gerrit.ovirt.org/20289
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I62aae14292bcc82412f1d45bd64f85fd7c5be161
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list