[node-patches] Change in ovirt-node[master]: New validation model should invalidate on custom plugin vali...

fabiand at fedoraproject.org fabiand at fedoraproject.org
Wed Oct 23 16:06:09 UTC 2013


Fabian Deutsch has submitted this change and it was merged.

Change subject: New validation model should invalidate on custom plugin validation
......................................................................


New validation model should invalidate on custom plugin validation

With the change to validation, we weren't able to invalidate a
page and changes by throwing an exception from plugin.on_change
because plugin.__invalid_changes didn't get populated by custom
validation. Do so.

Change-Id: Ib2b1943481af377ce629593725de03c9f6d58868
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/plugins.py
1 file changed, 10 insertions(+), 2 deletions(-)

Approvals:
  Fabian Deutsch: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19880
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2b1943481af377ce629593725de03c9f6d58868
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the node-patches mailing list