[node-patches] Change in ovirt-node[master]: puppet: add disable_puppet function into puppet_page

[rbarry at redhat.com]

Ryan Barry has posted comments on this change.

Change subject: puppet: add disable_puppet function into puppet_page
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

....................................................
File src/ovirt/node/setup/puppet/puppet_page.py
Line 179:         conf_builder = ""
Line 180:         for line in conf:
Line 181:             for item in item_args:
Line 182:                 line = re.sub(r'(^.*?' + item + ' =).*',
Line 183:                               r'#\1 "''"',
This won't have a capture group to place back in.
Line 184:                               line) if item in line else line
Line 185:             conf_builder += line
Line 186: 
Line 187:         conf.write(conf_builder, "w")


-- 
To view, visit http://gerrit.ovirt.org/20538
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I942252e228e9475c4c41e893aae6507b9505e245
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes