[node-patches] Change in ovirt-node[master]: firewall: No shell when cmd is a list

[fabiand at fedoraproject.org]

Fabian Deutsch has uploaded a new change for review.

Change subject: firewall: No shell when cmd is a list
......................................................................

firewall: No shell when cmd is a list

Change-Id: I778271bb878f78d3834976b0476b5c8a42c5041f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1007417
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/utils/firewall.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/04/19204/1

diff --git a/src/ovirt/node/utils/firewall.py b/src/ovirt/node/utils/firewall.py
index 960b3f2..5617cfa 100644
--- a/src/ovirt/node/utils/firewall.py
+++ b/src/ovirt/node/utils/firewall.py
@@ -49,7 +49,7 @@
 def setup_iptables(port, proto):
         cmd = ["iptables", "-I", "INPUT", "1", "-p", proto,
                "--dport", port, "-j", "ACCEPT"]
-        process.check_call(cmd, shell=True)
+        process.check_call(cmd)
 
 
 def setup_firewalld(port, proto):


-- 
To view, visit http://gerrit.ovirt.org/19204
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I778271bb878f78d3834976b0476b5c8a42c5041f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>