[node-patches] Change in ovirt-node[master]: support flash lights to identify which nics belong to bond

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: support flash lights to identify which nics belong to bond
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

....................................................
File src/ovirt/node/setup/core/network_page.py
Line 294:             self.logger.debug("Opening ping page")
Line 295:             self.application.switch_to_plugin(ping.Plugin)
Line 296:             return
Line 297: 
Line 298:         if "dialog.nic.identify" in changes:
Please use something like the following for this if-branch:

    ifname = self._model_extra["dialog.nic.ifname"]
    nic = utils.network.NodeNetwork().build_nic_model(ifname)
    nic.identify()
    self.application.notice("Flashing lights of '%s''" % nic)

.build_nic_model will discover what kind of nic ifname is and will create the correct nic subclass.

The above code needs to be tested!
Line 299:             ifname = self._model_extra["dialog.nic.ifname"]
Line 300:             if ifname[0:4] == "bond":
Line 301:                 mbond = defaults.NicBonding().retrieve()
Line 302:                 nic = utils.network.NIC(ifname)


-- 
To view, visit http://gerrit.ovirt.org/19175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5fa299cb84e2bcd3a873b9df88baee9f9d5cf7e1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes