[node-patches] Change in ovirt-node[master]: support flash lights to identify which nics belong to bond

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: support flash lights to identify which nics belong to bond
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

Just one really small nitpick.

....................................................
File src/ovirt/node/setup/core/network_page.py
Line 298:         if "dialog.nic.identify" in changes:
Line 299:             ifname = self._model_extra["dialog.nic.ifname"]
Line 300:             nic = utils.network.NodeNetwork().build_nic_model(ifname)
Line 301:             nic.identify()
Line 302:             self.application.notice("Flashing lights of '%s''" % nic.ifname)
There is one '  to much.
Line 303:             return
Line 304: 
Line 305:         nameservers = []
Line 306:         dns_keys = ["dns[0]", "dns[1]"]


-- 
To view, visit http://gerrit.ovirt.org/19175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5fa299cb84e2bcd3a873b9df88baee9f9d5cf7e1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes