[node-patches] Change in ovirt-node[master]: kdump_page: Catch KeyboardInterrupt when inputting "Ctrl+c"

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: kdump_page: Catch KeyboardInterrupt when inputting "Ctrl+c"
......................................................................


Patch Set 5:

(1 comment)

....................................................
File src/ovirt/node/setup/core/kdump_page.py
Line 167:                 progress_dialog.run()
Line 168:                 console.writeln("\nPlease press any key to continue")
Line 169:                 console.wait_for_keypress()
Line 170:         except KeyboardInterrupt:
Line 171:             with self.application.ui.suspended():
What is still missing is to inform the user that the configuration files were reset - otherwise it is not obvious to the user in what state the kdumpc fg is. Otherwise fine.
Line 172:                 model.update(None, None, None)
Line 173:                 txs = model.transaction()
Line 174:                 txs()
Line 175:         except Exception as e:


-- 
To view, visit http://gerrit.ovirt.org/18491
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7af3fc071db96a3c57c1b9fb76f4c3574250bef6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes