[node-patches] Change in ovirt-node[master]: ssh: Show consistent transaction

fabiand at fedoraproject.org fabiand at fedoraproject.org
Wed Sep 18 10:42:04 UTC 2013


Fabian Deutsch has uploaded a new change for review.

Change subject: ssh: Show consistent transaction
......................................................................

ssh: Show consistent transaction

Previously the transaction elements in appearing in the  transaction
used on the security page weren't obviously connected to the changes
done in the TUI.
Now the same transaction elements are used in the transaction.

Sometimes it's not possible to distinguish (in the defaults class) what
value changed. Therefor we are running all transaction elements and
don't try to be smart.
It could be solved by handling this in the TUI layer.

Change-Id: Idff93c3d8a59814941d1ed34d92c78c97a39d70d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=982425
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/config/defaults.py
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/59/19359/1

diff --git a/src/ovirt/node/config/defaults.py b/src/ovirt/node/config/defaults.py
index cab50ab..6d39226 100644
--- a/src/ovirt/node/config/defaults.py
+++ b/src/ovirt/node/config/defaults.py
@@ -1425,11 +1425,9 @@
                 ssh.disable_aesni(disable_aesni)
 
         tx = utils.Transaction("Configuring SSH")
-        if pwauth in [True, False]:
-            tx.append(ConfigurePasswordAuthentication())
+        tx.append(ConfigurePasswordAuthentication())
         tx.append(ConfigureStrongRNG())
-        if disable_aesni in [True, False]:
-            tx.append(ConfigureAESNI())
+        tx.append(ConfigureAESNI())
         return tx
 
 


-- 
To view, visit http://gerrit.ovirt.org/19359
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idff93c3d8a59814941d1ed34d92c78c97a39d70d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>



More information about the node-patches mailing list