[node-patches] Change in ovirt-node[master]: Make the kdump page work with new validation workflow

rbarry at redhat.com rbarry at redhat.com
Mon Sep 23 17:22:05 UTC 2013


Ryan Barry has uploaded a new change for review.

Change subject: Make the kdump page work with new validation workflow
......................................................................

Make the kdump page work with new validation workflow

kdump_page was still directly calling self.validate(), which no
longer works. Replace with a call to self._on_ui_change() to keep
the logic. Potentially remove altogether.

Change-Id: If4cb8101a58911ebd88f521f5e03ec1a32bee619
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/setup/core/kdump_page.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/86/19486/1

diff --git a/src/ovirt/node/setup/core/kdump_page.py b/src/ovirt/node/setup/core/kdump_page.py
index 3f87a8d..69206e5 100644
--- a/src/ovirt/node/setup/core/kdump_page.py
+++ b/src/ovirt/node/setup/core/kdump_page.py
@@ -130,8 +130,8 @@
 
             w = "kdump.%s_location" % changes["kdump.type"]
             if w in net_types and w in self.widgets:
-                self.widgets[w].enabled(True),
-                self.validate({w: ""})
+                self.widgets[w].enabled(True)
+                self._on_ui_change({w: ""})
 
     def on_merge(self, effective_changes):
         """Applies the changes to the plugins model, will do all required logic


-- 
To view, visit http://gerrit.ovirt.org/19486
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If4cb8101a58911ebd88f521f5e03ec1a32bee619
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>



More information about the node-patches mailing list