[node-patches] Change in ovirt-node[master]: kdump_page: only enable "ssh_key" entry when selecting "SSH"...

[rbarry at redhat.com]

Ryan Barry has posted comments on this change.

Change subject: kdump_page: only enable "ssh_key" entry when selecting "SSH" type
......................................................................


Patch Set 4:

(1 comment)

....................................................
File src/ovirt/node/setup/core/kdump_page.py
Line 134:                 self.widgets[w].enabled(True),
Line 135:                 self.validate({w: ""})
Line 136:                 if w == "kdump.ssh_location":
Line 137:                     self.widgets["kdump.ssh_key"].enabled(True),
Line 138:                     self.validate({"kdump.ssh_key": ""})
This logic (self.validate) shouldn't be necessary to activate a field any longer and doesn't work with the new validation workflow in any case. If it's still desired, you can self._on_ui_change({w: ""}) instead.
Line 139: 
Line 140:     def on_merge(self, effective_changes):
Line 141:         """Applies the changes to the plugins model, will do all required logic
Line 142:         Normally on_merge is called by pushing the SaveButton instance, in this


-- 
To view, visit http://gerrit.ovirt.org/18991
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65ba1684407180dc88a2dbb1917daa567354ba13
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes