[node-patches] Change in ovirt-node[master]: Get serial console working on Fedora and add TUI configuration

[rbarry at redhat.com]

Ryan Barry has posted comments on this change.

Change subject: Get serial console working on Fedora and add TUI configuration
......................................................................


Patch Set 5:

(1 comment)

....................................................
File src/ovirt/node/setup/core/status_page.py
Line 289:             utils.process.check_call("mount -o ro,remount %s" %
Line 290:                                      self.find_mount(grub_path), shell=True)
Line 291: 
Line 292:     def __find_mount(self, path):
Line 293:         while not os.path.ismount(path) and os.path != "/":
Typo there. It shold have been "and path != '/''", but because we're directly passing it the location of the grub config file without knowing where it's going to be, we're stepping all the way back.

So if it gets passed /dev/.initramfs/live/grub2/grub.cfg, we can go back to /dev/.initramfs/live. If it's /boot/grub/grub.conf, we can get /boot. 

Trying to arbitrarily figure out what the mountpoint which contains the directory we discovered is in order to mount it rw and modify grub.conf requires the loop. Worst case, we fall back to "/" and remount the entire filesystem rw (then edit grub.conf and remount ro).
Line 294:             path = os.path.dirname(path)
Line 295:         return path
Line 296: 
Line 297: 


-- 
To view, visit http://gerrit.ovirt.org/17982
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id99623830b56b77815196c8b0d153c86d3704f00
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes