[node-patches] Change in ovirt-node[master]: Validate passed NTP servers and reject bad ones

[jboggs at redhat.com]

Joey Boggs has posted comments on this change.

Change subject: Validate passed NTP servers and reject bad ones
......................................................................


Patch Set 2:

(1 comment)

....................................................
File scripts/ovirt-init-functions.sh.in
Line 654:         if valid.FQDNOrIPAddress()(x):
Line 655:             validservers.append(x)
Line 656: print ",".join(validservers)
Line 657: EOP
Line 658: `")
This throws an exception with invalid ones and will not continue onto testing the remaining ones, is that the intent (all or none)?
Line 659:             ;;
Line 660:             network_layout=*)
Line 661:             network_layout=${i#network_layout=}
Line 662:             ;;


-- 
To view, visit http://gerrit.ovirt.org/17888
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb135977b4359f5fe0161215cec2cdd1b22244b3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes