[node-patches] Change in ovirt-node[master]: process: pipe() can raise exception

mburns at redhat.com mburns at redhat.com
Mon Sep 30 13:26:58 UTC 2013


Michael Burns has submitted this change and it was merged.

Change subject: process: pipe() can raise exception
......................................................................


process: pipe() can raise exception

Previously the failed start of a service was not detected n el6, because
the fallback of check_output - pipe() - didn't throw exceptions on
failed starts. This is now fixed, pipe() is throwing (if asked)
exceptions to signla if th ecmd failed (the service didi not start).

Change-Id: I588d1b97d31553a1aaf05c0cd0462b118369179d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=991375
Signed-off-by: Fabian Deutsch <fabiand at fedoraproject.org>
---
M src/ovirt/node/utils/process.py
1 file changed, 79 insertions(+), 7 deletions(-)

Approvals:
  Michael Burns: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19621
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I588d1b97d31553a1aaf05c0cd0462b118369179d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mburns at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the node-patches mailing list