[node-patches] Change in ovirt-node[master]: Add an option to enable scsi_dh_alua

rbarry at redhat.com rbarry at redhat.com
Mon Sep 30 22:10:49 UTC 2013


Ryan Barry has uploaded a new change for review.

Change subject: Add an option to enable scsi_dh_alua
......................................................................

Add an option to enable scsi_dh_alua

Add an option on the storage page which adds a kernel argument to
enable scsi_dh_alua

Change-Id: I6cd913ef6cec4d5ce81637f540ed944bafde9daa
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1002862
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/setup/core/remote_storage_page.py
1 file changed, 11 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/08/19708/1

diff --git a/src/ovirt/node/setup/core/remote_storage_page.py b/src/ovirt/node/setup/core/remote_storage_page.py
index d68618c..901a106 100644
--- a/src/ovirt/node/setup/core/remote_storage_page.py
+++ b/src/ovirt/node/setup/core/remote_storage_page.py
@@ -22,6 +22,7 @@
 from ovirt.node.config import defaults
 from ovirt.node.plugins import Changeset
 from ovirt.node.utils import storage
+from ovirt.node.utils.system import Bootloader
 
 """
 Configure Remote Storage
@@ -40,9 +41,11 @@
     def model(self):
         icfg = defaults.iSCSI().retrieve()
         ncfg = defaults.NFSv4().retrieve()
+        boot = Bootloader()
         model = {}
         model["iscsi.initiator_name"] = icfg["name"] or \
             self.dry_or(lambda: storage.iSCSI().initiator_name())
+        model["scsi.dh_alua"] = boot.has_args("rdloaddriver=scsi_dh_alua")
         model["nfsv4.domain"] = ncfg["domain"]
         return model
 
@@ -53,6 +56,7 @@
 
     def ui_content(self):
         ws = [ui.Header("header", _("Remote Storage")),
+              ui.Checkbox("scsi.dh_alua", _("Enable SCSI DH_ALUA")),
               ui.Entry("iscsi.initiator_name", _("iSCSI Initiator Name:"),
                        align_vertical=True),
               ui.Divider("divider[0]"),
@@ -93,5 +97,12 @@
             model.update(*args)
             txs += model.transaction()
 
+        if "scsi.dh_alua" in changes:
+            b = Bootloader()
+            if changes["scsi.dh_alua"]:
+                b.update_args("rdloaddriver=scsi_dh_alua")
+            else:
+                b.remove_arg("rdloaddriver=")
+
         progress_dialog = ui.TransactionProgressDialog("dialog.txs", txs, self)
         progress_dialog.run()


-- 
To view, visit http://gerrit.ovirt.org/19708
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6cd913ef6cec4d5ce81637f540ed944bafde9daa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>



More information about the node-patches mailing list