[node-patches] Change in ovirt-node[master]: Put a close button on the ping page

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Put a close button on the ping page
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/26338/1/src/ovirt/node/setup/core/ping.py
File src/ovirt/node/setup/core/ping.py:

Line 99:         """
Line 100: 
Line 101:         if "ping.close" in effective_changes:
Line 102:             if ping.isAlive():
Line 103:                 ping._Thread__stop()
Please pull this into something like
ping.kill()
Line 104:             self.application.switch_to_plugin(
Line 105:                 network_page.Plugin)
Line 106:             return
Line 107:         elif "ping.address" in self._model:


-- 
To view, visit http://gerrit.ovirt.org/26338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b925443414df7e538310110e4b7a16d4244fcfd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes