[node-patches] Change in ovirt-node[master]: Fix remove_config issue for an unexistent file

fabiand at fedoraproject.org fabiand at fedoraproject.org
Wed Apr 2 08:53:28 UTC 2014


Fabian Deutsch has posted comments on this change.

Change subject: Fix remove_config issue for an unexistent file
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/26344/1/scripts/ovirt-functions.in
File scripts/ovirt-functions.in:

Line 741:             else
Line 742:                 printf "File not explicitly persisted: ${filename}\n"
Line 743:             fi
Line 744:             # clean up the persistent store
Line 745:             if [ x$filename != "x" ]; then
What about using

    if [[ ! -z $filename ]]; then
Line 746:                 rm -Rf /config$filename
Line 747:             fi
Line 748:         done
Line 749:     fi


-- 
To view, visit http://gerrit.ovirt.org/26344
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2eea0f9d96e616ad45633243f94ecb84ddd7ae86
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Wenyi Gao <wenyi at linux.vnet.ibm.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes



More information about the node-patches mailing list