[node-patches] Change in ovirt-node[master]: More F20 node cleanup

fabiand at fedoraproject.org fabiand at fedoraproject.org
Wed Apr 2 15:59:19 UTC 2014


Fabian Deutsch has posted comments on this change.

Change subject: More F20 node cleanup
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.ovirt.org/#/c/25909/12/tools/edit-node
File tools/edit-node:

Line 1212:             # ensure that isofs is included - needed to boot from a LiveCD
Line 1213:             dracut_conf.write('add_drivers+="isofs"\n')
Line 1214:             dracut_conf.write('hostonly="no"\n')
Line 1215:             dracut_conf.close()
Line 1216:         cmd = 'sed -ie \'s/^hostonly="yes"/hostonly="no"/\' ' + \
What is actually happening here?
Line 1217:               '/usr/lib/dracut/dracut.conf.d/01-dist.conf'
Line 1218:         f = subprocess.Popen(cmd, shell=True, stdout=PIPE, stderr=STDOUT,
Line 1219:                              preexec_fn=self._chroot)
Line 1220:         output, err = f.communicate()


-- 
To view, visit http://gerrit.ovirt.org/25909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66f9b26a470d8b6ca76c65abb0031757e2932a17
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes



More information about the node-patches mailing list