[node-patches] Change in ovirt-node[master]: edit-node: handle the "file://" type of baseurl for yum repo

[jboggs at redhat.com]

Joey Boggs has posted comments on this change.

Change subject: edit-node: handle the "file://" type of baseurl for yum repo
......................................................................


Patch Set 5: Verified-1

This looks ok, but fails when a directory doesn't exist for instance say the local repo is in /home/user/dir

/home/user does not exist within the iso fs. I'd say to create a directory under the iso's /tmp dir and modify the file path inside the copied XXX.repo file and cleanup  the tmp dir on the way back out.

-- 
To view, visit http://gerrit.ovirt.org/21244
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic44264f0c62c8785c0b4867fda1e45522d32fc1f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No