[node-patches] Change in ovirt-node[master]: fix list index error on plugins page when a manifest file do...

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: fix list index error on plugins page when a manifest file does not exist
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/26376/4/src/ovirt/node/setup/core/plugins_page.py
File src/ovirt/node/setup/core/plugins_page.py:

Line 114:                     with open(fn) as src:
Line 115:                         contents = src.read()
Line 116:                     return ui.TextViewDialog("output.dialog", "Manifest",
Line 117:                                              contents)
Line 118:                 except:
Please log the exact error here, just for debugging:

    self.debug("Failed ot retrieve manifest or so", exc_info=True)
Line 119:                     return InfoDialog("dialog.info", "An Error Occured",
Line 120:                                       "No manifest found")
Line 121: 
Line 122:     def __list_of_plugins(self):


-- 
To view, visit http://gerrit.ovirt.org/26376
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d82583b3aee98b6b544ec89b75fa4f6ea314685
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes