[node-patches] Change in ovirt-node[master]: Put a close button on the ping page

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Put a close button on the ping page
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/26338/2/src/ovirt/node/setup/core/ping.py
File src/ovirt/node/setup/core/ping.py:

Line 71:         ws = [ui.Header("ping.header", _("Ping a remote host")),
Line 72:               ui.Entry("ping.address", _("Address:")),
Line 73:               ui.Entry("ping.count", _("Count:")),
Line 74:               ui.Divider("divider[1]"),
Line 75:               ui.SaveButton("ping.do_ping", _("Ping")),
Could we put the <Ping> and <Close> either in the same row or add a divider between them - looks weird otherwise to me.

In general. Doesn't the <Close> button only make sense for Dialogs Should we make this a dialog?
Line 76:               ui.Button("ping.close", _("Close")),
Line 77:               ui.Divider("divider[2]"),
Line 78:               ui.Label("ping.result", _("Result:")),
Line 79:               ]


-- 
To view, visit http://gerrit.ovirt.org/26338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b925443414df7e538310110e4b7a16d4244fcfd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes