[node-patches] Change in ovirt-node[master]: [DRAFT] add hosted-engine support

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: [DRAFT] add hosted-engine support
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.ovirt.org/#/c/26201/1/src/Makefile.am
File src/Makefile.am:

Line 70: pyovirt_node_setup_cimdir = $(pyovirt_node_setupdir)/cim
Line 71: pyovirt_node_setup_snmpdir = $(pyovirt_node_setupdir)/snmp
Line 72: pyovirt_node_setup_puppetdir = $(pyovirt_node_setupdir)/puppet
Line 73: pyovirt_node_setup_ipmidir = $(pyovirt_node_setupdir)/ipmi
Line 74: pyovirt_node_setup_hostedenginedir = $(pyovirt_node_setupdir)/hosted-engine
If you don't mind, could you remove the dash from the path (so: hostedengine or he)
Line 75: 
Line 76: 
Line 77: pyovirt_PYTHON = \
Line 78:   ovirt/__init__.py


http://gerrit.ovirt.org/#/c/26201/1/src/ovirt/node/setup/hosted-engine/hosted_engine_page.py
File src/ovirt/node/setup/hosted-engine/hosted_engine_page.py:

Line 23: from ovirt.node.plugins import Changeset
Line 24: from ovirt_hosted_engine_ha.client import client
Line 25: import os
Line 26: 
Line 27: VM_CONF_PATH = "/etc/ovirt-hosted-engine/vm.conf"
Do we need to persist this?

Do we need to persist other files?

Or is this done by the hosted-engine-setup?
Line 28: """
Line 29: Configure Hosted Engine
Line 30: """
Line 31: 


Line 77:               ]
Line 78: 
Line 79:         page = ui.Page("page", ws)
Line 80:         page.buttons = [ui.Button("action.setupengine",
Line 81:                                   "Setup Hosted Engine")
Maybe also a button to remove/reinstall hosted engine? With a confirmation dialog ...
Line 82:                         ]
Line 83:         self.widgets.add(page)
Line 84:         return page
Line 85: 


Line 99:             self.logger.debug("Starting drop to setup")
Line 100:             utils.console.writeln("Beginning Hosted Engine Setup ...")
Line 101: 
Line 102:             def open_console():
Line 103:                 utils.process.call("reset; screen ovirt-hosted-engine-setup",
I need to do this once manually to see what is happening
Line 104:                                    shell=True)
Line 105: 
Line 106:             def return_ok(dialog, changes):
Line 107:                 with self.application.ui.suspended():


Line 110:             try:
Line 111:                 txt = "Setup will be ran with screen enabled that can be "
Line 112:                 txt += "reconnected in the event of a timeout or connection "
Line 113:                 txt += "failure.\n"
Line 114:                 txt += "\nIt can be reconnected by running 'screen -d -r'"
Can we possibly detect if a disconnect happened and offer a button to reconnect to this?
Line 115: 
Line 116:                 dialog = ui.ConfirmationDialog("dialog.shell",
Line 117:                                                "Begin Hosted Engine Setup", txt
Line 118:                                                )


-- 
To view, visit http://gerrit.ovirt.org/26201
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I602266200b2f062fe299de5329987c85f2494512
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes