[node-patches] Change in ovirt-node[master]: Make the logrotate interval configurable

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Make the logrotate interval configurable
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.ovirt.org/#/c/26130/2/logrotate/ovirt-logrotate.conf
File logrotate/ovirt-logrotate.conf:

Line 1: /var/log/ovirt*.log {
Just for documentation purpose could you please add a comment here saying what this configuraiton does?
Line 2:     rotate 3
Line 3:     compress
Line 4:     missingok
Line 5:     minsize 1M


http://gerrit.ovirt.org/#/c/26130/2/src/ovirt/node/config/defaults.py
File src/ovirt/node/config/defaults.py:

Line 1331:                         interval)
Line 1332:                 ovirt_store_config("/etc/logrotate.d/ovirt-node")
Line 1333: 
Line 1334:         tx = utils.Transaction("Configuring logrotate")
Line 1335:         if max_size:
We also need to handle the case to unset the max_size
Line 1336:             tx.append(CreateLogrotateConfig())
Line 1337:         if interval:
Line 1338:             tx.append(SetLogrotateInterval())
Line 1339:         return tx


Line 1333: 
Line 1334:         tx = utils.Transaction("Configuring logrotate")
Line 1335:         if max_size:
Line 1336:             tx.append(CreateLogrotateConfig())
Line 1337:         if interval:
Same as above. (None case)
Line 1338:             tx.append(SetLogrotateInterval())
Line 1339:         return tx
Line 1340: 
Line 1341: 


http://gerrit.ovirt.org/#/c/26130/2/src/ovirt/node/setup/core/logging_page.py
File src/ovirt/node/setup/core/logging_page.py:

Line 73:     def ui_content(self):
Line 74: 
Line 75:         ws = [ui.Header("header[0]", _("Logging")),
Line 76:               ui.Label("logrotate.header",
Line 77:                        _("oVirt logs will be rotated at the specified ") +
Please don't use the product name here, might not match other products names.

But a nice explanation
Line 78:                        _("size not more often than the specified interval")),
Line 79:               ui.Entry("logrotate.max_size", _("Logrotate Max Log ") +
Line 80:                        _("Size (KB):")),
Line 81:               ui.Options("logrotate.interval", _("Interval"),


-- 
To view, visit http://gerrit.ovirt.org/26130
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb2639225f8b793b302e36a2c7639cb0769d4df4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes