[node-patches] Change in ovirt-node[master]: init: Add support for reboot_delay cmdline args

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: init: Add support for reboot_delay cmdline args
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.ovirt.org/#/c/20351/12/scripts/ovirt-auto-install.py
File scripts/ovirt-auto-install.py:

Line 239:        not OVIRT_VARS["OVIRT_REBOOT_DELAY"] is "":
Line 240:         print "Reboot Scheduled in %s seconds later" % \
Line 241:               OVIRT_VARS["OVIRT_REBOOT_DELAY"]
Line 242:         time.sleep(int(OVIRT_VARS["OVIRT_REBOOT_DELAY"]))
Line 243:         os.execl(which("reboot"), which("reboot"))
Why not os.system?

The construct above looks a bit weird execl(reboot, reboot) ...
Line 244: 


-- 
To view, visit http://gerrit.ovirt.org/20351
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee9888ddfd0323e37a6c8524043cf4e21e9e2166
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes