[node-patches] Change in ovirt-node[master]: Don't show configured NICs in the bond dialog

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: Don't show configured NICs in the bond dialog
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/26626/1/src/ovirt/node/setup/core/network_page.py
File src/ovirt/node/setup/core/network_page.py:

Line 53:                                        header,
Line 54:                                        self._get_nics(filter),
Line 55:                                        height=height, multi=multi),
Line 56: 
Line 57:     def _get_nics(self, filter):
please give this a more descriptive name, e.g.: filter_configured
Line 58:         def justify(txt, l):
Line 59:             txt = txt if txt else ""
Line 60:             return txt.ljust(l)[0:l]
Line 61:         node_nics = []


Line 70:                 is_cfg = ("Configured" if nic.is_configured() else
Line 71:                           "Unconfigured")
Line 72: 
Line 73:             if is_cfg == "Configured" and filter:
Line 74:                 pass
I believe you need continue here, not pass -- pass is noop
Line 75: 
Line 76:             fields = [justify(nic.ifname, 7),
Line 77:                       justify(is_cfg, 12)]
Line 78: 


-- 
To view, visit http://gerrit.ovirt.org/26626
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79095cf299f5194b3466d09e35894ecd7affc279
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes