[node-patches] Change in ovirt-node[master]: hooks: ignore non pyc files during autoinstall

fabiand at redhat.com fabiand at redhat.com
Thu Aug 7 09:30:25 UTC 2014


Fabian Deutsch has submitted this change and it was merged.

Change subject: hooks: ignore non pyc files during autoinstall
......................................................................


hooks: ignore non pyc files during autoinstall

Generating an image without image-minimizer.ks the .py an
.pyo files will remain in the ISO.
However, the current hook logic is check if the hook file is .py
and execute it calling with python binary or execute the script
directly. Based in that assumption, .pyc and .pyo will be called
as script and will make the autoinstall fail.
This patch, removes the duplicate code around this logic and
will ignore .py and .pyo files, executing only .pyc or any other
hook script.

Change-Id: I8c87a3db450ac4c4172c5540f7552c0e03d90066
Signed-off-by: Douglas Schilling Landgraf <dougsland at redhat.com>
---
M src/ovirt/node/utils/hooks.py
1 file changed, 8 insertions(+), 7 deletions(-)

Approvals:
  Fabian Deutsch: Verified; Looks good to me, approved
  Douglas Schilling Landgraf: Verified



-- 
To view, visit http://gerrit.ovirt.org/31173
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8c87a3db450ac4c4172c5540f7552c0e03d90066
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the node-patches mailing list