[node-patches] Change in ovirt-node[master]: Fix the installer for EL7 and general logic changes

[dougsland at redhat.com]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Fix the installer for EL7 and general logic changes
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/31544/3/src/ovirtnode/ovirtfunctions.py
File src/ovirtnode/ovirtfunctions.py:

Line 521:     else:
Line 522:         if is_iscsi_install():
Line 523:             connect_iscsi_root()
Line 524:         system_closefds("mkdir -p /liveos")
Line 525:         if not "CDLABEL" in open("/proc/cmdline").read()
missed ':' from if.
Line 526:             if not system("mount LABEL=Root /liveos &>/dev/null"):
Line 527:                 # just in case /dev/disk/by-label is not using devmapper and fails
Line 528:                 for dev in os.listdir("/dev/mapper"):
Line 529:                     if system("e2label \"/dev/mapper/" + dev + "\" 2>/dev/null|grep Root|grep -v Backup"):


-- 
To view, visit http://gerrit.ovirt.org/31544
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I327fb0026d739361ad5c932a12cf3b536057be9a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes