[node-patches] Change in ovirt-node[master]: Additional input parameter check to persist and unpersist fu...

fabiand at redhat.com fabiand at redhat.com
Mon Dec 1 15:51:08 UTC 2014


Fabian Deutsch has posted comments on this change.

Change subject: Additional input parameter check to persist and unpersist function in fs utils. Passing None as path will no longer cause for a crash.
......................................................................


Patch Set 3:

(1 comment)

Patch is good. Just the msg needs one more update.

http://gerrit.ovirt.org/#/c/35749/3//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-12-01 14:54:48 +0200
Line 4: Commit:     Tolik Litovsky <tlitovsk at redhat.com>
Line 5: CommitDate: 2014-12-01 17:11:40 +0200
Line 6: 
Line 7: Additional input parameter check to persist and unpersist function in fs
Please add a new-line between the Title (first line) and the first description line(should be in the third line). Otherwise gitk and other tools will start to cry ..
Line 8: utils. Passing None as path will no longer cause for a crash.
Line 9: 
Line 10: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1154356
Line 11: Change-Id: Icd6a0010e4ffdfd92b83506f1809ff54f5f40e10


-- 
To view, visit http://gerrit.ovirt.org/35749
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd6a0010e4ffdfd92b83506f1809ff54f5f40e10
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes



More information about the node-patches mailing list