[node-patches] Change in ovirt-node[ovirt-3.5]: Set plugin.__changes to Changeset on reset, not dict

[fabiand at redhat.com]

Hello Ryan Barry,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/35852

to review the following change.

Change subject: Set plugin.__changes to Changeset on reset, not dict
......................................................................

Set plugin.__changes to Changeset on reset, not dict

Setting it to an empty dict on on_ui_reset is unnecessary when
Changeset is superset of dict, and some workflows rely on
__changes being a changeset...

Change-Id: I2e47c72686eda2dbf5e7d1657675ab7fe5469e0e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1166036
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M src/ovirt/node/plugins.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/52/35852/1

diff --git a/src/ovirt/node/plugins.py b/src/ovirt/node/plugins.py
index a66a1d4..0ea70c8 100644
--- a/src/ovirt/node/plugins.py
+++ b/src/ovirt/node/plugins.py
@@ -438,7 +438,7 @@
         """
         changes = self.pending_changes(False)
         self.logger.debug("Request to discard model changes: %s" % changes)
-        self.__changes = {}
+        self.__changes = Changeset()
 
     def __effective_changes(self):
         """Calculates the effective changes, so changes which change the


-- 
To view, visit http://gerrit.ovirt.org/35852
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e47c72686eda2dbf5e7d1657675ab7fe5469e0e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>