[node-patches] Change in ovirt-node-iso[master]: Makefile now point to correct repositories

[fabiand at redhat.com]

Fabian Deutsch has posted comments on this change.

Change subject: Makefile now point to correct repositories
......................................................................


Patch Set 3:

(1 comment)

A great and welcome simplification, but some comment on the required repos is inline.

http://gerrit.ovirt.org/#/c/36277/3/Makefile.am
File Makefile.am:

Line 93:         CENTOS_REPO_LINE="repo --name=centos --mirrorlist=$(CENTOS_MIRROR)?release=$(CENTOS)&arch=${ARCH}&repo=os \n" ;\
Line 94:         UPDATES_REPO_LINE="repo --name=centos-updates --mirrorlist=$(CENTOS_MIRROR)?release=$(CENTOS)&arch=${ARCH}&repo=updates \n" ;\
Line 95:         EPEL_REPO_LINE="repo --name=epel --baseurl=http://dl.fedoraproject.org/pub/epel/$(CENTOS)/${ARCH} \n" ;\
Line 96:         OVIRT_REPO_LINE="repo --name=ovirt-repo --baseurl=$(OVIRT_BASE_URL)/el$(CENTOS)\n" ;\
Line 97: 		GLUSTER_REPO_LINE="repo --name=gluster-3.4 --baseurl=http://download.gluster.org/pub/gluster/glusterfs/3.4/3.4.0/CentOS/epel-6Server/x86_64/\n" ;\
We must use glusterfs 3.6, but this repo, and all the repos below can be pulled from this file:

http://resources.ovirt.org/pub/ovirt-3.5/rpm/el6/noarch/ovirt-release35-001-1.noarch.rpm

This contains all the repos which we need to include.
It would be best if we extracted the informations from that rpm.
This is actually done here:
http://gerrit.ovirt.org/gitweb?p=ovirt-node-iso.git;a=blob;f=generate-repos.sh;h=52a6090697e1e8481ff1c050040a317826688506;hb=refs/heads/ovirt-3.5
Line 98:         printf "$${CENTOS_REPO_LINE}" > repos.ks ;\
Line 99:         printf "$${UPDATES_REPO_LINE}" >> repos.ks ;\
Line 100:         printf "$${EPEL_REPO_LINE}" >> repos.ks ;\
Line 101:         printf "$${OVIRT_REPO_LINE}" >> repos.ks ;\


-- 
To view, visit http://gerrit.ovirt.org/36277
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If640a55b555b7a31f67b83826ae7579b11409e00
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-node-iso
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes