[node-patches] Change in ovirt-node[node-3.0]: Hooks should work in ovirt-node-upgrade

[fabiand at fedoraproject.org]

Hello Ryan Barry,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/24768

to review the following change.

Change subject: Hooks should work in ovirt-node-upgrade
......................................................................

Hooks should work in ovirt-node-upgrade

os.path.join() discards previous entries if one starts with /.
Previously, ovirt-node-upgrade tried to run all hooks from the
running image and not the one being upgraded to. It should run
from the chroot instead.

Change-Id: I0627d89165002a33ea060b4be2bc03282854bcc3
Signed-off-by: Ryan Barry <rbarry at redhat.com>
---
M scripts/ovirt-node-upgrade.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-node refs/changes/68/24768/1

diff --git a/scripts/ovirt-node-upgrade.py b/scripts/ovirt-node-upgrade.py
index adfb707..16a6533 100755
--- a/scripts/ovirt-node-upgrade.py
+++ b/scripts/ovirt-node-upgrade.py
@@ -130,7 +130,7 @@
             "LiveOS",
             "ext3fs.img",
         )
-        self._hooks_path = "/usr/libexec/ovirt-node/hooks/"
+        self._hooks_path = "usr/libexec/ovirt-node/hooks/"
         self._logger.info("Temporary Directory is: %s", self._tmp_dir)
 
     def _system(self, *command):


-- 
To view, visit http://gerrit.ovirt.org/24768
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0627d89165002a33ea060b4be2bc03282854bcc3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: node-3.0
Gerrit-Owner: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>