[node-patches] Change in ovirt-node[master]: kdump:Fix not enough arguments given exception

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: kdump:Fix not enough arguments given exception
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/24534/2/src/ovirt/node/config/defaults.py
File src/ovirt/node/config/defaults.py:

Line 1019: 
Line 1020:     def configure_nfs(self, nfs_location):
Line 1021:         self.update(nfs_location, None, None, None)
Line 1022: 
Line 1023:     def configure_ssh(self, ssh_location):
Can't we just add the key= argument here, so:

    def configure_ssh(self, ssh_location, ssh_key=None):
Line 1024:         self.update(None, ssh_location, None, None)
Line 1025: 
Line 1026:     def configure_ssh_key(self, ssh_location, ssh_key):
Line 1027:         self.update(None, ssh_location, ssh_key, None)


Line 1022: 
Line 1023:     def configure_ssh(self, ssh_location):
Line 1024:         self.update(None, ssh_location, None, None)
Line 1025: 
Line 1026:     def configure_ssh_key(self, ssh_location, ssh_key):
… then we can drop this member
Line 1027:         self.update(None, ssh_location, ssh_key, None)
Line 1028: 
Line 1029:     def configure_local(self):
Line 1030:         self.update(None, None, None, True)


-- 
To view, visit http://gerrit.ovirt.org/24534
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93c7c99990a9f622ba2d38345d1ff5adfcdbe03
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes