[node-patches] Change in ovirt-node[master]: edit-node: handle the "file://" type of baseurl for yum repo

fabiand at fedoraproject.org fabiand at fedoraproject.org
Thu Feb 20 10:47:25 UTC 2014


Fabian Deutsch has posted comments on this change.

Change subject: edit-node: handle the "file://" type of baseurl for yum repo
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/21244/2/tools/edit-node
File tools/edit-node:

Line 965:                     output, err = f.communicate()
Line 966:                     if f.returncode > 0:
Line 967:                         print cmd
Line 968:                         print output
Line 969:                         print "Can't Bind Mount rpm directory"
Please print this to stderr
Line 970:                         return False
Line 971:                 return True
Line 972:             elif os.path.isdir(options.repo) or \
Line 973:                     options.repo.lower().endswith(".iso"):


-- 
To view, visit http://gerrit.ovirt.org/21244
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic44264f0c62c8785c0b4867fda1e45522d32fc1f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes



More information about the node-patches mailing list