[node-patches] Change in ovirt-node[master]: [DRAFT] Docker build support for Node

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: [DRAFT] Docker build support for Node
......................................................................


Patch Set 1:

(1 comment)

Something minor

http://gerrit.ovirt.org/#/c/24679/1/docker/buildovirt.sh
File docker/buildovirt.sh:

Line 35: else
Line 36:   git fetch $1 && git checkout FETCH_HEAD
Line 37: fi
Line 38: make distclean
Line 39: ./autogen.sh --with-image-minimizer 
Ryan, there is a trailing whitespace!!!! :)
Line 40: make iso publish
Line 41: CONFIGURE_ARGS="--with-recipe=../ovirt-node/recipe"
Line 42: if [ ! -z $BUILD_NUMBER ]; then
Line 43:   CONFIGURE_ARGS+=" --with-build-number=$BUILD_NUMBER"


-- 
To view, visit http://gerrit.ovirt.org/24679
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2ebfdc53ebe76636aa5a7553b750be67e58312
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes