[node-patches] Change in ovirt-node[master]: re-write auto install function for the cim plugin

[fabiand at fedoraproject.org]

Fabian Deutsch has posted comments on this change.

Change subject: re-write auto install function for the cim plugin
......................................................................


Patch Set 14: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/20641/14/plugins/cim_autoinstall.py
File plugins/cim_autoinstall.py:

Line 43:     effective_model.update(changes)
Line 44:     is_enabled = effective_model["cim.enabled"]
Line 45:     pw = effective_model["cim.password"] or \
Line 46:          _functions.OVIRT_VARS["OVIRT_CIM_PASSWD"]
Line 47:     print pw
Bad - don't print a password
Line 48:     cim.update(is_enabled)
Line 49:     tx = cim.transaction(cim_password=pw)
Line 50:     TransactionProgress(tx, is_dry=False).run()
Line 51:     # clear ovirt_cim_passwd from /etc/default/ovirt


-- 
To view, visit http://gerrit.ovirt.org/20641
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35e6971a7cd7ba4f742c734dadbd20a8c4b594bb
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-node
Gerrit-Branch: master
Gerrit-Owner: hadong <hadong0720 at gmail.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes